New manifest and action level logs with new strip and tail options #303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #303 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 27 27
Lines 1246 1242 -4
Branches 218 218
=========================================
- Hits 1246 1242 -4
Continue to review full report at Codecov.
|
purplecabbage
approved these changes
Oct 14, 2020
| } | ||
| filterActions = [actionName] | ||
| } else { | ||
| Object.entries(config.manifest.full.packages).forEach((packageTuple) => { |
There was a problem hiding this comment.
this is a little gnarly, not sure it could be any better though
| description: 'strip timestamp information and output first line only', | ||
| default: false | ||
| }), | ||
| tail: flags.boolean({ |
There was a problem hiding this comment.
is tail our final choice? should we alias it with watch?
what is the point of adding a default for -a? if they want to get logs for an action or actions, they would need to specify it ...
There was a problem hiding this comment.
thx @purplecabbage . Removed action default and added aliases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #96 among other enhancements as described in https://wiki.corp.adobe.com/display/AdobeCloudPlatform/Consolidation+of+logs+command+in+runtime+and+app+plugins
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: